On Sat. 5 Nov. 2022 at 18:11, Vincent Mailhol <vincent.mailhol@xxxxxxxxx> wrote: > On Sat. 5 Nov. 2022 at 02:29, Harald Mommer <Harald.Mommer@xxxxxxxxxxxxxxx> wrote: > > +/* CAN flags to determine type of CAN Id */ > > +#define VIRTIO_CAN_FLAGS_EXTENDED 0x8000u > > +#define VIRTIO_CAN_FLAGS_FD 0x4000u > > +#define VIRTIO_CAN_FLAGS_RTR 0x2000u > > I recommend the use of the BIT() macro to declare flags. I just remembered that the BIT() macro is not meant to be used for UAPI. Please ignore this particular comment. > Please order those in ascending order. > Also, what is the reason to start from BIT(9) (0x200)? [...]
