On Sat. 5 Nov. 2022 at 17:36, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Sat, Nov 05, 2022 at 02:16:04AM +0900, Vincent Mailhol wrote: > > ES58x devices report below information in their usb product info > > string: > > > > * the firmware version > > * the bootloader version > > * the hardware revision > > > > Report the firmware version through ethtool_drvinfo::fw_version. > > Because struct ethtool_drvinfo has no fields to report the boatloader > > version nor the hardware revision, continue to print these in the > > kernel log (c.f. es58x_get_product_info()). > > > > While doing so, bump up copyright year of each modified files. > > Why not just stick to the normal USB interface here and not try to tie > it into ethtool? These values are all availble today in sysfs or in > libusb, right? The simple answer is ignorance. I am more familiar with ethtool than libusb and I just did not think to explore that second option. Thanks for the review, comments taken. I will study sysfs and libusb and will rework that. > What workflow wants this added to ethtool? No workflow. My work is not bound to any company and this driver maintenance and anything else I am doing on the mailing list at this time is pure hobby. Yours sincerely, Vincent Mailhol
