On 31.10.2022 20:27:14, Jakub Kicinski wrote: > On Mon, 31 Oct 2022 16:43:52 +0100 Marc Kleine-Budde wrote: > > The first 7 patches are by Stephane Grosjean and Lukas Magel and > > target the peak_usb driver. Support for flashing a user defined device > > ID via the ethtool flash interface is added. A read only sysfs > > nit: ethtool eeprom set != ethtool flash Right, the driver uses the eeprom callbacks of ethtool. > > attribute for that value is added to distinguish between devices via > > udev. > > So the user can write an arbitrary u32 value into flash which then > persistently pops up in sysfs across reboots (as a custom attribute > called "user_devid")? ACK - Some devices support a u32, others only a u8. > I don't know.. the whole thing strikes me as odd. Greg do you have any > feelings about such.. solutions? > > patches 5 and 6 here: > https://lore.kernel.org/all/20221031154406.259857-1-mkl@xxxxxxxxxxxxxx/ Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
