On Thu. 21 Jul. 2022 at 16:53, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote: > On 21.07.2022 09:36:21, Oliver Hartkopp wrote: > > Btw. How should we finally name the 'non data' header of CAN XL? > > > > 1. CANXL_HEADER_SIZE > > 2. CANXL_HEAD_SIZE > > 3. CANXL_HDR_SIZE > > 4. CANXL_HDR_SZ <- currently in the patches > > 5. CANXL_HD_SZ > > > > I think it has to be 'head' and not 'header'. > > Header! Header is in front of data. I am also part of the header team! By analogy with: https://en.wikipedia.org/wiki/IPv4#Header > > In skbs we also have head and tail. > > Yes, but they point at the head or tail of the buffer allocated with the > skb. > > > So I would vote for 2 or 5 with a tendency to 5. > > 3, 1, 4 My top vote goes to: 6. No macro, instead use flexible array member and do sizeof(struct canxl_frame) I do not like the SZ abbreviation either, so my next choices will be 3 then 1. To recap: 6, 3, 1.
