Re: [PATCH v2 0/3] can: kvaser_usb: CAN clock frequency regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/4/22 15:07, Marc Kleine-Budde wrote:
On 03.06.2022 10:38:17, Jimmy Assarsson wrote:
When fixing the CAN clock frequency,
fb12797ab1fe ("can: kvaser_usb: get CAN clock frequency from device"),
I introduced a regression.

For Leaf devices based on M32C, the firmware expects bittiming parameters
calculated for 16MHz clock. Regardless of the actual clock frequency.

This regression affects M32C based Leaf devices with non-16MHz clock.

Also correct the bittiming constants in kvaser_usb_leaf.c, where the limits
are different depending on which firmware/device being used.

Once merged to mainline, I'll backport these fixes for the stable kernels.

Added to linux-can/testing. I had to move the kvaser_usb_driver_info
into kvaser_usb_core.c and the keep struct can_bittiming_const
kvaser_usb_flexc_bittiming_const in kvaser_usb_hydra.c as structs in
header files cause defined but not used warnings on some platforms.

Ok. Thanks Marc!



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux