On 07.06.2022 11:47:45, Dario Binacchi wrote: > This is a preparation patch for the upcoming support to change the > bitrate via ip tool, reset the adapter error states via the ethtool API > and, more generally, send commands to the adapter. > > Since some commands (e. g. setting the bitrate) will be sent before > calling the open_candev(), the netif_running() will return false and so > a new flag bit (i. e. SLF_XCMD) for serial transmission has to be added. > > Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx> I think this patch can be dropped, let me explain: You don't have to implement the do_set_bittiming callback. It's perfectly OK to set the bitrate during the ndo_open callback after open_candev(). regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
