Re: [PATCH 0/2] can: drop tx skb if the device is in listen only mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.05.2022 23:23:53, Vincent Mailhol wrote:
> In listen only mode, tx CAN frames can still reach the driver if
> injected via the packet socket. This series add a check toward
> CAN_CTRLMODE_LISTENONLY in can_dropped_invalid_skb() to discard such
> skb. The first patch does some preparation work and migrates
> can_dropped_invalid_skb() from skb.h to dev.h. The second and last
> patch is the actual change.

Thanks for your quick patch!

What about moving the function to a .c file? The
can_dropped_invalid_skb() grew a lot over the years, since it was added
to the header as a static inline function.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux