On 12.02.2022 22:27:27, Vincent Mailhol wrote:
> The can help menu misses three spaces for the TDCV, TDCO and TDCF
> parameters, making the closing curly bracket unaligned.
>
> For reference, before this patch:
>
> | $ ip link help can
> | Usage: ip link set DEVICE type can
> | [ bitrate BITRATE [ sample-point SAMPLE-POINT] ] |
> | [ tq TQ prop-seg PROP_SEG phase-seg1 PHASE-SEG1
> | phase-seg2 PHASE-SEG2 [ sjw SJW ] ]
> |
> | [ dbitrate BITRATE [ dsample-point SAMPLE-POINT] ] |
> | [ dtq TQ dprop-seg PROP_SEG dphase-seg1 PHASE-SEG1
> | dphase-seg2 PHASE-SEG2 [ dsjw SJW ] ]
> | [ tdcv TDCV tdco TDCO tdcf TDCF ]
> |
> | [ loopback { on | off } ]
> | [ listen-only { on | off } ]
> | [ triple-sampling { on | off } ]
> | [ one-shot { on | off } ]
> | [ berr-reporting { on | off } ]
> | [ fd { on | off } ]
> | [ fd-non-iso { on | off } ]
> | [ presume-ack { on | off } ]
> | [ cc-len8-dlc { on | off } ]
> | [ tdc-mode { auto | manual | off } ]
> |
> | [ restart-ms TIME-MS ]
> | [ restart ]
> |
> | [ termination { 0..65535 } ]
> |
> | Where: BITRATE := { NUMBER in bps }
> | SAMPLE-POINT := { 0.000..0.999 }
> | TQ := { NUMBER in ns }
> | PROP-SEG := { NUMBER in tq }
> | PHASE-SEG1 := { NUMBER in tq }
> | PHASE-SEG2 := { NUMBER in tq }
> | SJW := { NUMBER in tq }
> | TDCV := { NUMBER in tc}
> | TDCO := { NUMBER in tc}
> | TDCF := { NUMBER in tc}
> | RESTART-MS := { 0 | NUMBER in ms }
>
> ... and after this patch:
>
> | $ ip link help can
> | Usage: ip link set DEVICE type can
> | [ bitrate BITRATE [ sample-point SAMPLE-POINT] ] |
> | [ tq TQ prop-seg PROP_SEG phase-seg1 PHASE-SEG1
> | phase-seg2 PHASE-SEG2 [ sjw SJW ] ]
> |
> | [ dbitrate BITRATE [ dsample-point SAMPLE-POINT] ] |
> | [ dtq TQ dprop-seg PROP_SEG dphase-seg1 PHASE-SEG1
> | dphase-seg2 PHASE-SEG2 [ dsjw SJW ] ]
> | [ tdcv TDCV tdco TDCO tdcf TDCF ]
> |
> | [ loopback { on | off } ]
> | [ listen-only { on | off } ]
> | [ triple-sampling { on | off } ]
> | [ one-shot { on | off } ]
> | [ berr-reporting { on | off } ]
> | [ fd { on | off } ]
> | [ fd-non-iso { on | off } ]
> | [ presume-ack { on | off } ]
> | [ cc-len8-dlc { on | off } ]
> | [ tdc-mode { auto | manual | off } ]
> |
> | [ restart-ms TIME-MS ]
> | [ restart ]
> |
> | [ termination { 0..65535 } ]
> |
> | Where: BITRATE := { NUMBER in bps }
> | SAMPLE-POINT := { 0.000..0.999 }
> | TQ := { NUMBER in ns }
> | PROP-SEG := { NUMBER in tq }
> | PHASE-SEG1 := { NUMBER in tq }
> | PHASE-SEG2 := { NUMBER in tq }
> | SJW := { NUMBER in tq }
> | TDCV := { NUMBER in tc }
> | TDCO := { NUMBER in tc }
> | TDCF := { NUMBER in tc }
> | RESTART-MS := { 0 | NUMBER in ms }
>
> Fixes: 0c263d7c36ff ("iplink_can: add new CAN FD bittiming parameters:
> Transmitter Delay Compensat ion (TDC)")
> Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
Acked-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
