This series was born from the review https://lkml.org/lkml/2022/1/2/127 by Marc Kleine-Budde. The ethtool module is minimal and lacks the callback to change the setting at runtime (this has yet to be defined). I'm certainly not an expert but might it make sense to use the set_features() callback? Although I understand that it belongs to `struct net_device_ops' and not to 'struct ethtool_ops'. Dario Binacchi (2): can: flexcan: allow to change quirks at runtime can: flexcan: add ethtool support drivers/net/can/Makefile | 3 + drivers/net/can/flexcan.h | 107 +++++++++++++ drivers/net/can/flexcan_ethtool.c | 29 ++++ drivers/net/can/{flexcan.c => flexcan_main.c} | 144 ++++-------------- 4 files changed, 166 insertions(+), 117 deletions(-) create mode 100644 drivers/net/can/flexcan.h create mode 100644 drivers/net/can/flexcan_ethtool.c rename drivers/net/can/{flexcan.c => flexcan_main.c} (92%) -- 2.32.0
