On 25.07.2021 19:44:43, Yasushi SHOJI wrote: > Hi Pavel, > > On Sun, Jul 25, 2021 at 5:12 PM Pavel Skripkin <paskripkin@xxxxxxxxx> wrote: > > Can You try the following patch? > > > > diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c > > index a45865bd7254..a1a154c08b7f 100644 > > --- a/drivers/net/can/usb/mcba_usb.c > > +++ b/drivers/net/can/usb/mcba_usb.c > > @@ -653,6 +653,8 @@ static int mcba_usb_start(struct mcba_priv *priv) > > break; > > } > > > > + urb->transfer_dma = buf_dma; > > + > > usb_fill_bulk_urb(urb, priv->udev, > > usb_rcvbulkpipe(priv->udev, MCBA_USB_EP_IN), > > buf, MCBA_USB_RX_BUFF_SIZE, > > Yup, this patch fixed it. I've tested on top of v5.10.52. > > Tested-by: Yasushi SHOJI <yashi@xxxxxxxxxxxxxxx> > > > I am sorry for breaking your device :( > > No problem. It'd be nice if we'd test with real hardware before > merging into the stable tree, though. Yes absolutely - but I don't have access to that hardware. Since you're interested in that hardware, what about adding you as a reviewer to the kernel. Then for every change on this driver, you'll be added on Cc and can test it. What do you think? > Anyway, thank you for your quick fix! regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
