On 21.06.2021 22:22:50, Geert Uytterhoeven wrote: > Hi Marc, > > On Mon, Jun 21, 2021 at 10:18 PM Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote: > > On 21.06.2021 22:11:58, Geert Uytterhoeven wrote: > > > On Mon, Jun 21, 2021 at 8:47 PM Angelo Dureghello > > > <angelo@xxxxxxxxxxxxxxxx> wrote: > > > > Update flexcan to support architectures without fdt. > > > > > > > > Signed-off-by: Angelo Dureghello <angelo@xxxxxxxxxxxxxxxx> > > > > --- > > > > Changes for v2: > > > > none > > > > Changes for v3: > > > > - change to just remove OF > > > > --- > > > > drivers/net/can/Kconfig | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig > > > > index e355d3974977..a0f4ae7ccb84 100644 > > > > --- a/drivers/net/can/Kconfig > > > > +++ b/drivers/net/can/Kconfig > > > > @@ -97,7 +97,7 @@ config CAN_AT91 > > > > > > > > config CAN_FLEXCAN > > > > tristate "Support for Freescale FLEXCAN based chips" > > > > - depends on OF && HAS_IOMEM > > > > + depends on HAS_IOMEM > > > > > > I think you want to add a line > > > > > > depends on ARCH_LAYERSCAPE || ARCH_MXC || COLDFIRE || > > > FSL_SOC_BOOKE || COMPILE_TEST > > > > > > (or PPC instead of FSL_SOC_BOOKE?) > > > so the question doesn't pop up when compiling a kernel for a system > > > that cannot have a Freescale FlexCAN IP block. > > > > Back in 2018 Pankaj Bansal replaced the "depends on ARM || PPC" by "OF > > && HAS_IOMEM", see: > > > > | 0f8af56f74cd can: flexcan: enable flexcan for all architectures > > Probably the real reason behind that was to enable it on ARM64 > (more specifically ARCH_LAYERSCAPE || ARCH_MXC). Probably. What about the original proposed change: "(OF || M5441x) && HAS_IOMEM"? > > So I think there won't be too many configs where the oldconfig question > > would pop up. > > Now it will, as Mr. Torvalds' main machine does not satisfy "ARM || PPC" > or "OF && HAS_IOMEM", but does "HAS_IOMEM" ;-) IC, that would be one question too much :) Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
