While doing tests on TDC, I witnessed a strange behavior: the data
bittiming are still displayed after turning fd to off.
$ ip link set can0 type can bitrate 500000 dbitrate 2000000 fd on
$ ip link set can0 type can bitrate 500000 fd off
$ ip --details link show can0
1: can0: <NOARP,ECHO> mtu 16 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 10
link/can promiscuity 0 minmtu 0 maxmtu 0
can state STOPPED restart-ms 0
bitrate 500000 sample-point 0.875
tq 12 prop-seg 69 phase-seg1 70phase-seg2 20 sjw 1 brp 1
ES582.1/ES584.1: tseg1 2..256 tseg2 2..128 sjw 1..128 brp 1..512 brp_inc 1
dbitrate 2000000 dsample-point 0.750
dtq 12 dprop-seg 14 dphase-seg1 15 dphase-seg2 10 dsjw 1 dbrp 1
tdcv 0 tdco 30 tdcf 0
ES582.1/ES584.1: dtseg1 2..32 dtseg2 1..16 dsjw 1..8 dbrp 1..32 brp_inc 1
tdcv_max 0 tdco_max 127 tdcf_max 127
clock 80000000 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
This series comports two patches: one for the data bittiming parameters, one of the tdc parameters.
If possible, I wish to have the second patch squashed in the netlink
TDC series. I put comments after the --- cutter.
Vincent Mailhol (2):
can: netlink: clear data_bittiming if fd is turned off
can: netlink: clear tdc if fd is turned off
drivers/net/can/dev/netlink.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
2.31.1
