On 14.05.2021 15:44:34, Torin Cooper-Bennun wrote: > On Fri, May 14, 2021 at 04:12:37PM +0200, Marc Kleine-Budde wrote: > > > The TCAN4550 has interrupts that cannot be disabled or masked, including > > > those for faults involving SPI, power, and transceiver issues (e.g. CAN > > > stuck dominant). > > > > Ah, ok. Do they need any handling/acknowledge? You only read TCAN4X5X_INT_FLAGS, are > > those clear-or-read? > > In theory, for any of these, clearing the register should be sufficient > for the interrupt pin to go inactive... emphasis on "in theory". Ok, but as you noticed in your patch, if no IRQ is pending in M_CAN_IR, the main driver doesn't call the tcan4x5x handler. So the IRQ stays active, the IRQ handler is repeatedly called and returns IRQ_NONE. Then you get the nobody cared warning. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
