On Tue. 2 Feb 2021 à 18:16, Oliver Hartkopp <socketcan@xxxxxxxxxxxx> wrote: > On 02.02.21 10:05, Marc Kleine-Budde wrote: > > On 2/2/21 10:00 AM, Oliver Hartkopp wrote: > >>>> IMO, can_frames in the tx path with CAN_ERR_FLAG should be dropped > >>>> if the driver can't handle them. vcan in this regard is capable of > >>>> handling those, as does the kvaser usb. > >>> > >>> Makes sense. The implementation steps could be: > >>> - convert can_dropped_invalid_skb() from static inline to > >>> regular function > >>> - add check for CAN_ERR_FLAG and enabled CAN_CTRLMODE_TX_ERR > >>> to can_dropped_invalid_skb() Back to the idea of my initial e-mail :) > >> Which means the vcan has to support CAN_CTRLMODE_TX_ERR too. > >> > >>>> I think it's wrong that CAN_ERR_FLAG messages would appear as regular > >>>> frame on CAN, as happens today if I understood well. > >>> > >>> ACK If we could go in the past, those should have appeared on the error socket. > >> What happens if you send a valid CAN frame with CAN_ERR_FLAG set? > >> > >> I did not check it but I assume the frame is sent as normal frame and > >> the echo'ed CAN frame would *only* go through the error message filter > >> bank in af_can.c. > > > > If CAN_CTRLMODE_TX_ERR has been added to the kernel and > > can_dropped_invalid_skb() is updated, then a CAN frame with CAN_ERR_FLAG set > > would be either send as an error frame or dropped by can_dropped_invalid_skb(). > > > > So it would be echoed only if the driver supports CAN_CTRLMODE_TX_ERR and it's > > enabled. > > ACK. The echo would be special here. We have to remember that the payload of the CAN_ERR_FLAG frames is an arbitrary design. This payload has no meaning for the data link. When we echo back the frame, only the DLC, CAN ID and payload of the TX frame are irrelevant (except for vcan). My current idea would be to follow what Kvaser did: they send the frame and the device reports the error flag (c.f. the example given by Jimmy above). So the echo feature would not be used for error flags. @Jimmy, could you confirm my understanding? Do you use the echo functionality for error flags in the Kvaser driver? > So a second time Vincent found a mismatch nobody cared about so far. > Congrats, Vincent! > (no irony here) > > ;-) Thanks, this is me wearing my hacker's goggles. > >> This is probably not what we want for 'real' CAN devices, so we might > >> have to take a look at this too. > > > > Marc > >
