Hi Jimmy, On Tue. 2 Feb 2021 at 00:41, Jimmy Assarsson <extja@xxxxxxxxxx> wrote: > On 2021-02-01 15:19, Vincent MAILHOL wrote: > > Hi Jimmy, > > On Mon. 1 Feb 2021 at 05:42, Jimmy Assarsson <jimmyassarsson@xxxxxxxxx> wrote: > >> On 2021-01-31 13:59, Oliver Hartkopp wrote: > >>> Hi Vincent, > >>> On 31.01.21 07:22, Vincent MAILHOL wrote: > >>>> Hello, > >>>> > >>>> The socket CAN API handles the CAN errors (as reported by the > >>>> microcontroller) by emitting some RX CAN frames with the > >>>> CAN_ERR_FLAG set. > >>> > >>> Yes. This is the only intention. > >>> > >>>> My question concerns the transmission path: I would like to > >>>> understand how drivers should handle *TX* CAN frames which have > >>>> the CAN_ERR_FLAG set. > >>>> > >>>> The socket API allows sending such frames. For example doing: > >>>> cansend can0 20000123#0011223344556677 > >>>> will generate such frames and it will reach the xmit() function of > >>>> the driver. > >>> > >>> The reason to pass the frame as-is to the driver layer (including CAN_ERR_FLAG) is the possibility to test the correct behavior on the RX path, e.g. when you use the vcan driver. > >>> > >>> On the sending path the CAN_ERR_FLAG has no functionality so far - at least it was not defined by the community. > >>> > >>>> However, contrary to the other flags (EFF, RTR, FDF, BRS), the > >>>> ERR flag is not present on the data link layer. Instead, the data > >>>> link layer is responsible for detecting errors and signaling those > >>>> as soon as they occur (thus interrupting the transmission). > >>>> > >>>> While the ISO standard does not explicitly forbid having upper > >>>> layers generating such frames, it is not documented. Also, I am > >>>> not aware of CAN controllers allowing to generate error frames on > >>>> demand. > >>> > >>> There are specialized CAN testers, e.g. IIRC Vector CANstress that can generate error frames on specific conditions (e.g. when detecting a specific CAN ID). > >>> > >>> But I heave not seen CAN controllers that provide such functionality. > >>> > >>>> My initial expectation is that those error frames only make > >>>> sense in the RX path and that we should drop such TX frames in, > >>>> for example, can_dropped_invalid_skb(). > >>> > >>> No. As written above the bit is defined to be valid in the RX path only and it makes sense for testing. > >>> > >>>> However, after looking at the code of other drivers, it appears > >>>> that one (and only one) of them: the Kvaser hydra, does actually > >>>> check this CAN_ERR_FLAG flag in the TX path: > >>>> https://elixir.bootlin.com/linux/v5.11-rc5/source/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c#L1421 > >>>> > >>>> I would be thankful if anyone knowledgeable about the Kvaser hydra > >>>> could explain to me how the device handles those error frames. > >>> > >>> o_O - Yes, would be interested too!! > >> > >> Hi Vincent and Oliver, > >> > >> When the user passes a frame with CAN_ERR_FLAG set, the CAN controller will generate an error frame. > >> We got customers that use this for testing system robustness and fault reporting/handling. > > > > Interesting. > > > > There are two forms of error flags: > > - The active error flag: 6 consecutive dominant bits > > - The passive error flag: 6 consecutive recessive bits > > Can it generate both or only one of these? Is it generated as > > soon as the device receives the command or is it generated at a > > predefined timing (e.g. beginning of the frame)? > > It can only generate the active error flag. > It will generate an error frame on the bus as soon as the bus is idle. > > $ sudo ip link set can4 type can bitrate 100000 > $ sudo ip link set can5 type can bitrate 100000 > $ sudo ip link set can4 up > $ sudo ip link set can5 up > $ ./candump -c -ta -H -d -e -x can4,#FFFFFFFF & > [1] 177884 > $ ./cansend can5 20000000# > (0000000084.786201) can4 RX - - 20000080 [8] 00 00 00 00 00 00 > 00 01 ERRORFRAME > bus-error > error-counter-tx-rx{{0}{1}} > $ ./cansend can5 20000123#0011223344556677 > (0000000086.798898) can4 RX - - 20000080 [8] 00 00 00 00 00 00 > 00 02 ERRORFRAME > bus-error > error-counter-tx-rx{{0}{2}} > $ ./cansend can5 20000000# > (0000000087.385292) can4 RX - - 20000080 [8] 00 00 00 00 00 00 > 00 03 ERRORFRAME > bus-error > error-counter-tx-rx{{0}{3}} > $ ./cansend can5 20000000# > (0000000087.911860) can4 RX - - 20000080 [8] 00 00 00 00 00 00 > 00 04 ERRORFRAME > bus-error > error-counter-tx-rx{{0}{4}} > $ ./cansend can5 20000000# > (0000000088.404890) can4 RX - - 20000080 [8] 00 00 00 00 00 00 > 00 05 ERRORFRAME > bus-error > error-counter-tx-rx{{0}{5}} > $ ./cansend can5 005#FF.12.20 > (0000000093.061655) can4 RX - - 005 [3] FF 12 20 > $ ./cansend can5 005#FF.12.21 > (0000000094.667557) can4 RX - - 005 [3] FF 12 21 > $ ./cansend can5 005#FF.12.22 > (0000000095.617019) can4 RX - - 005 [3] FF 12 22 > $ ./cansend can5 20000000# > (0000000097.883071) can4 RX - - 20000080 [8] 00 00 00 00 00 00 > 00 03 ERRORFRAME > bus-error > error-counter-tx-rx{{0}{3}} Thanks for the example, things are now clear. So the error flag always increments the RX counter even if you are the transmitter. > > > Which CAN microcontroller is used inside the device? > > It is an IP developed by Kvaser called KCAN. I'm not sure, but I think > it has only been used in FPGAs. This makes more sense. As I wrote before, I did not know of any microcontroller allowing you to generate error flags on demand. So you build your device on an FPGA to be able to control the bit level. Nice! I also once wanted to use an FPGA to play with error flags but it only remained an idea. > > Also, could you point me to the Kvaser hydra product page? I > > couldn't find it with a quick search so I figured out that maybe > > the commercial name is different? > > Hydra is the name of the platform for the USB based products. > You find all devices with this capability here: > https://www.kvaser.com/products-services/our-products/#/?descriptors=can_fd,err_frame_gen&pc_int=mini-pci-express,pci-express,usb > As mentioned before, the SocketCAN driver for the PCIe based devices > does not support this. Thanks! > >> We also got this implemented in the early version of kvaser_pciefd driver, but dropped it: > >> https://marc.info/?l=linux-can&m=154324867704480&w=2 > >> Is this something that we should remove from kvasr_usb aswell? > > > > No. My intent is not to ask you to remove it. It is rather the > > opposite: I want to understand more how you are able to achieve > > what I thought not to be possible. For what you told me, the > > Kvaser hydra is the kind of device which I would like to have in > > my testing environment :) > > > > However, it would make sense to normalize this use case in the > > Socket CAN interface. For the discussion with Oliver, it is clear > > that this use case is currently not expected and undefined, the > > reason being that such a CAN controller was not thought to > > exist. Now that you have proved us wrong, things are different. > > Right, it would be nice to sort this out. I prefer to keep the > functionality, since we got customers using it. Basically, I would see this as an expert function: add a CAN_CTRLMODE_TX_ERR and have the user explicitly enable the feature through netlink when configuring the interface. The rationale is to prevent by default an unprivileged application from messing with the bus. If CAN_CTRLMODE_TX_ERR is on the device generates an error flag. Else, the CAN_ERR_FLAG is simply ignored (masked out). The CAN ID, DLC and payload of the TX error frames are ignored (i.e. reserved for future). I do not see the need for more complex logic at the moment because your device is only capable of generating one type of error flags: the active error. If one day a device has the ability to generate both the active and passive error flags, we should then define how to send those (maybe by putting a flag in the payload, similar to what is done on the RX path). What do you think of the above? Yours sincerely, Vincent
