Re: [net-next v2 05/15] can: dev: move skb related into seperate file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon. 11 Jan 2021 at 23:20, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>
> On 1/11/21 1:51 PM, Vincent MAILHOL wrote:
> > On Mon. 11 Jan 2021 at 19:45, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> >>
> >> This patch moves the skb related code of the CAN device infrastructure into a
> >> separate file.
> >>
> >> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> >> ---
> >>  drivers/net/can/dev/dev.c | 213 ------------------------------------
> >>  drivers/net/can/dev/skb.c | 220 ++++++++++++++++++++++++++++++++++++++
> >>  include/linux/can/dev.h   |  76 -------------
> >>  include/linux/can/skb.h   |  77 +++++++++++++
> >>  4 files changed, 297 insertions(+), 289 deletions(-)
> >>  create mode 100644 drivers/net/can/dev/skb.c
> >>
> >> [...]
> >
> > Sorry but the changes on drivers/net/can/dev/Makefile are still
> > missing for the skb patch (however, it is now OK for the
> > netlink).
>
> Hopefully fixed this time. Seems I have to compile the whole kernel to notice
> the missing symbols :/

Yep, no more compilation issues!

I will do a few more tests but your v3 seems to be the good
one.

Will also adapt the changes to the ES58x driver and send my v10,
probably tomorrow (it's time to go to bed here).


Yours sincerely,
Vincent



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux