Re: [PATCH v2] can: dev: can_put_echo_skb(): extend to store can frame length

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon. 11 Jan 2021 at 19:54, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>
> On 1/11/21 11:41 AM, Vincent Mailhol wrote:
> > Add a frame_len argument to can_put_echo_skb() which is used to save
> > length of the CAN frame into field frame_len of struct can_skb_priv so
> > that it can be later used after transmission completion. Convert all
> > users of this function, too.
> >
> > Drivers which implement BQL call can_put_echo_skb() with the output of
> > can_skb_get_frame_len(skb) and drivers which do not simply pass zero
> > as an input (in the same way that NULL would be given to
> > can_get_echo_skb()). This way, we have a nice symmetry between the two
> > echo functions.
> >
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> > --
> > v2: make the assignemend unconditional.
> >
> > Hi Marc,
> >
> > If you like the idea to modify can_put_echo_skb(), you can use this
> > patch. Just put it between patches 12 and 13 of your series.
>
> I think I've done the same changes, why applying. The series I just send is
> based on your v1 with my changes.

No problem, I just missed your message saying that you will do
the changes.

The only difference is the change in the patch subject but that's
really a minor detail. The content is the same.


Yours sincerely,
Vincent



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux