Re: [net-next 00/13] can: dev: cleanup and add CAN frame length handling support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon. 11 Jan 2021 at 17:26, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>
> On 1/10/21 9:55 AM, Vincent MAILHOL wrote:
> [...]
>
> > Did you test it after the occurence of a can_bus_off() event?
>
> Not yet...
>
> > When the device restarts, you normally have to call
> > netdev_reset_queue(netdev) in order to reset all the BQL
> > statistics.
>
> I only included the relevant parts to illustrate the use of the changed API.
> There is a netdev_reset_queue() in mcp251xfd_ring_init(), which is called via:
> mcp251xfd_chip_start(), mcp251xfd_set_mode()

Great then! I was just worried not to see it mentioned in the
patch.

As a global comment for the series: I am done with my comments,
looking forward to the v2!


Yours sincerely,
Vincent



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux