On 1/11/21 9:22 AM, Marc Kleine-Budde wrote: [...] >> But the absence of symmetry in the final result bothers me a >> bit. Reading manually can_skb_prv(skb)->frame_len by hand would >> look as below, which I think is short enough not to be >> factorized within can_get_echo_skb(): >> struct sk_buff *skb = priv->echo_skb[skb_idx]; >> unsigned int frame_len = can_skb_prv(skb)->frame_len; >> can_get_echo_skb(skb, netdev, skb_idx); >> >> So at the end, I would suggest not to modify can_get_echo_skb() >> so that it is a better "mirror" of can_put_echo_skb(). > > That is the logical next step, which I didn't take :) need more tee! I ment to say your "[PATCH] can: dev: extend can_put_echo_skb() to handle frame_len" is the next logical step. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: OpenPGP digital signature
