This patch simplifies the tcan4x5x_regmap_write(0 function by removing not needed casts and replaces hardcoded "4" by appropriate sizeof()s. Reviewed-by: Dan Murphy <dmurphy@xxxxxx> Tested-by: Sean Nyekjaer <sean@xxxxxxxxxx> Link: https://lore.kernel.org/r/20201215231746.1132907-10-mkl@xxxxxxxxxxxxxx Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> --- drivers/net/can/m_can/tcan4x5x-regmap.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/m_can/tcan4x5x-regmap.c b/drivers/net/can/m_can/tcan4x5x-regmap.c index 8f718f4395c3..6345bcb7704f 100644 --- a/drivers/net/can/m_can/tcan4x5x-regmap.c +++ b/drivers/net/can/m_can/tcan4x5x-regmap.c @@ -38,10 +38,9 @@ static int tcan4x5x_regmap_gather_write(void *context, const void *reg, static int tcan4x5x_regmap_write(void *context, const void *data, size_t count) { - u16 *reg = (u16 *)(data); - const u32 *val = data + 4; - - return tcan4x5x_regmap_gather_write(context, reg, 4, val, count - 4); + return tcan4x5x_regmap_gather_write(context, data, sizeof(u32), + data + sizeof(u32), + count - sizeof(u32)); } static int tcan4x5x_regmap_read(void *context, -- 2.29.2
