Re: [RFC]: tcan4x5x: rework regmap support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc

On 12/15/20 5:17 PM, Marc Kleine-Budde wrote:
Hello,

this series first cleans up the the SPI regmap and then fixes several problem:
- tcan4x5x_regmap_gather_write(), tcan4x5x_regmap_read():
   Do not place variable "addr" on stack and use it as buffer for SPI
   transfer. Buffers for SPI transfers must be allocated from DMA save
   memory.
- tcan4x5x_regmap_gather_write(), tcan4x5x_regmap_read():
   Halfe number of SPI transfers by using a single buffer + memcpy().
   This improves the performance, especially on SPI controllers, which
   use interrupt based transfers.
- Use "8" bits per word, not "32". This makes it possible to use this
   driver on SoCs like the Raspberry Pi, which SPI host controller
   drivers only support 8 bits per word.

With this series, the driver is able to detect a tcan4x5x on a Raspberry Pi.

regards,
Marc

Thanks for the clean up.

Reviewed-by: Dan Murphy <dmurphy@xxxxxx>

Dan





[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux