Re: [PATCH 2/2] can: dev: can_skb_get_dll_len(): introduce function to get data length of frame in data link layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/15/20 2:09 PM, Oliver Hartkopp wrote:
>> + * rounded up and ignoring bitsuffing
> 
> bitsTuffing :-)
> 
> and in all the other copy/paste locations too

fixed - Tnx.

[...]

> Would it make sense to move these definitions and/or the below code into 
> a separate can_dll.h file?

ACK, after we've decided on proper naming I'll move this into a seperate file.
> we have separated the code to calculate these kind of things in 
> canframelen.[ch] in the can-utils too.

good idea!

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux