On Fri, 27 Nov 2020 20:35:55 +0100 Marc Kleine-Budde wrote:
> On 11/27/20 5:27 PM, Jakub Kicinski wrote:
> > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote:
> >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote:
> >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> >>> These are simple defines so they could be used in DTS but they will not
> >>> have the same meaning:
> >>> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> >>> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
> >>>
> >>> Correct the interrupt flags, assuming the author of the code wanted same
> >>> logical behavior behind the name "ACTIVE_xxx", this is:
> >>> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
> >>> ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >>> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> >>> Acked-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> # for tcan4x5x.txt
> >>
> >> Jakub, can you queue this patch for net/master?
> >
> > Sure! Are these correct?
> >
> > Fixes: a1a8b4594f8d ("NFC: pn544: i2c: Add DTS Documentation")
> > Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver")
>
> ACK:
Applied to net and queued for stable, thanks!
