RE: [net] can: m_can: fix nominal bitiming tseg2 min for version >= 3.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Subject: [net] can: m_can: fix nominal bitiming tseg2 min for version >=
3.1
> 
> At lest the revision 3.3.0 of the bosch m_can IP core specifies that valid
> register values for "Nominal Time segment after sample point (NTSEG2)" are
> from
> 1 to 127. As the hardware uses a value of one more than the programmed
> value, mean tseg2_min is 2.
> 
> This patch fixes the tseg2_min value accordingly.
>

Acked-by: Sriram Dash <sriram.dash@xxxxxxxxxxx>

> Cc: Dan Murphy <dmurphy@xxxxxx>
> Cc: Sriram Dash <sriram.dash@xxxxxxxxxxx>
> Cc: Mario Huettel <mario.huettel@xxxxxxx>
> Cc: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx>
> Fixes: b03cfc5bb0e1 ("can: m_can: Enable M_CAN version dependent
> initialization")
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> ---
>  drivers/net/can/m_can/m_can.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c
> b/drivers/net/can/m_can/m_can.c index f3fc37e96b08..86bbbfa2d743
> 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1033,7 +1033,7 @@ static const struct can_bittiming_const
> m_can_bittiming_const_31X = {
>  	.name = KBUILD_MODNAME,
>  	.tseg1_min = 2,		/* Time segment 1 = prop_seg + phase_seg1
> */
>  	.tseg1_max = 256,
> -	.tseg2_min = 1,		/* Time segment 2 = phase_seg2 */
> +	.tseg2_min = 2,		/* Time segment 2 = phase_seg2 */
>  	.tseg2_max = 128,
>  	.sjw_max = 128,
>  	.brp_min = 1,
> --
> 2.29.2
> 





[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux