On 04.11.20 17:02, Jakub Kicinski wrote:
On Wed, 4 Nov 2020 15:59:25 +0100 Oliver Hartkopp wrote:
On 04.11.20 09:16, Eric Dumazet wrote:
So skb_orphan(skb) in CAN before calling netif_rx() is better IMO.
Unfortunately you missed the answer from Vincent, why skb_orphan() does
not work here:
https://lore.kernel.org/linux-can/CAMZ6RqJyZTcqZcq6jEzm5LLM_MMe=dYDbwvv=Y+dBR0drWuFmw@xxxxxxxxxxxxxx/
Okay, we can take this as a quick fix but to me it seems a little
strange to be dropping what is effectively locally generated frames.
Thanks! So this patch doesn't hinder Marc's PR :-)
Can we use a NAPI poll model here and back pressure TX if the echo
is not keeping up?
Some of the CAN network drivers already support NAPI.
@Marc: Can we also use NAPI for echo'ing the skbs?
Best regards,
Oliver
