On 11/4/20 4:57 PM, yegorslists@xxxxxxxxxxxxxx wrote: > From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx> > > Use table markup to show the structure of the CAN identifier, PGN, PDU1, > and PDU2 formats. Also add introductory sentence. > > Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx> > --- > Documentation/networking/j1939.rst | 46 +++++++++++++++++++++++++++--- > 1 file changed, 42 insertions(+), 4 deletions(-) > > diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst > index 0a4b73b03b99..19d9878d7194 100644 > --- a/Documentation/networking/j1939.rst > +++ b/Documentation/networking/j1939.rst > @@ -69,18 +69,56 @@ J1939 concepts > PGN > --- > > +The J1939 protocol uses the 29-bit CAN identifier with the following structure: > + > + ============ ============== ==================== > + 29 bit CAN-ID > + -------------------------------------------------- > + Bit positions within the CAN-ID > + -------------------------------------------------- > + 28 ... 26 25 ... 8 7 ... 0 > + ============ ============== ==================== > + Priority PGN SA (Source Address) > + ============ ============== ==================== Here you introduce trailing whitespace. I've removed them while applying the patch to linux-can/testing Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: OpenPGP digital signature
