Re: [PATCH can-next] can: add ISO 15765-2:2016 transport protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 06.10.20 22:27, Marc Kleine-Budde wrote:
On 9/28/20 10:04 PM, Oliver Hartkopp wrote:
CAN Transport Protocols offer support for segmented Point-to-Point
communication between CAN nodes via two defined CAN Identifiers.
As CAN frames can only transport a small amount of data bytes
(max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this
segmentation is needed to transport longer PDUs as needed e.g. for
vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN traffic.
This protocol driver implements data transfers according to
ISO 15765-2:2016 for 'classic' CAN and CAN FD frame types.

Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>

Applied to linux-can-next with some changes:

diff --git a/net/can/isotp.c b/net/can/isotp.c
new file mode 100644
index 000000000000..efed3e47b6ee
--- /dev/null
+++ b/net/can/isotp.c
@@ -0,0 +1,1428 @@
+// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)

Removed the syscall note, as it's only ment for header files. See:

     d77cd7fefc0d can: remove "WITH Linux-syscall-note" fro
                       SPDX tag of C files


Oh, my bad. I was working on Linus' tree when creating the patch and missed that cleanup I acked myself m(

Further I've fixes some indention, a checkpatch warning and some typos.

Thanks! I did not get the point with the (id) macro - now it's clear ;-)

Best,
Oliver



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux