Re: [BUG] pfifo_fast may cause out-of-order CAN frame transmission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Paolo,

On 1/20/20 5:06 PM, Ahmad Fatoum wrote:
> Hello Paolo,
> 
> On 1/16/20 1:40 PM, Paolo Abeni wrote:
>> I'm sorry for this trial & error experience. I tried to reproduce the
>> issue on top of the vcan virtual device, but it looks like it requires
>> the timing imposed by a real device, and it's missing here (TL;DR: I
>> can't reproduce the issue locally).
> 
> No worries. I don't mind testing.
> 
>>
>> Code wise, the 2nd patch closed a possible race, but it dumbly re-
>> opened the one addressed by the first attempt - the 'empty' field must
>> be cleared prior to the trylock operation, or we may end-up with such
>> field set and the queue not empty.
>>
>> So, could you please try the following code?
> 
> Unfortunately, I still see observe reodering.

Any news?

Thanks
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux