Re: [mkl-can:testing 1/1] include/linux/can/dev.h:113: undefined reference to `can_skb_headroom_valid'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/10/19 9:17 AM, Oliver Hartkopp wrote:
> I built a Linux 5.5 rc1 with your patch without any problems. Any idea 
> about this kbuild test failure?
> 
> So far vcan.o was not linked to dev.o as we only had the inline 
> functions can_dropped_invalid_skb() and can_create_echo_skb() in dev.h.

I think the problem is that you can build the some drivers without
activating CAN_DEV. This means the dev.c is not compied, thus the symbol
is not available.

For linux-can-next, I suggest to drop the optional CAN_DEV and compile
it unconditionally if CAN is switched on.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux