On 09/12/2019 14.08, Dan Murphy wrote:
Sean
On 12/9/19 3:37 AM, Sriram Dash wrote:
From: linux-can-owner@xxxxxxxxxxxxxxx <linux-can-
owner@xxxxxxxxxxxxxxx> On Behalf Of Sean Nyekjaer
Sent: 09 December 2019 14:45
Subject: [PATCH] can: m_can: remove double clearing of clock stop
request
bit
In m_can_config_endisable the CSA bit cleared 2 times while enabling
configuration mode.
Should have been CSR here...
According to the datasheet:
If a Read-Modify-Write operation is performed in Standby mode a CSR = 1
will be read back but a 0 should be written to it.
Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
Acked-by: Sriram Dash <sriram.dash@xxxxxxxxxxx>
I am not sure that this code is doing what you ask.
I think this commit message needs to indicate that you are removing the
duplicate clearing of the CSR bit
Yes see above ^^
Because the same code check and clears the CSR bit on line 379 as well.
CSR doesn't get more cleared, by clearing it two times in a row :)
The bit need to be cleared when both enabling and disabling
configuration mode.
Dan it's quite weird I'm only receiving your replies via the mailing
list, that's why I was kinda slow writing this answer :)
/Sean
