Sean
On 12/9/19 3:37 AM, Sriram Dash wrote:
From: linux-can-owner@xxxxxxxxxxxxxxx <linux-can-
owner@xxxxxxxxxxxxxxx> On Behalf Of Sean Nyekjaer
Sent: 09 December 2019 14:45
Subject: [PATCH] can: m_can: remove double clearing of clock stop request
bit
In m_can_config_endisable the CSA bit cleared 2 times while enabling
configuration mode.
According to the datasheet:
If a Read-Modify-Write operation is performed in Standby mode a CSR = 1
will be read back but a 0 should be written to it.
Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
Acked-by: Sriram Dash <sriram.dash@xxxxxxxxxxx>
I am not sure that this code is doing what you ask.
I think this commit message needs to indicate that you are removing the
duplicate clearing of the CSR bit
Because the same code check and clears the CSR bit on line 379 as well.
---
drivers/net/can/m_can/m_can.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c
b/drivers/net/can/m_can/m_can.c index 02c5795b7393..4edc6f6e5165
100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -380,10 +380,6 @@ void m_can_config_endisable(struct
m_can_classdev *cdev, bool enable)
cccr &= ~CCCR_CSR;
if (enable) {
- /* Clear the Clock stop request if it was set */
- if (cccr & CCCR_CSR)
- cccr &= ~CCCR_CSR;
-
I need to test this on the TCAN part. This was added specifically for it.
Dan
