On 10/8/19 10:24 AM, Jeroen Hofstee wrote:
> Hello Kurt,
>
> On 10/8/19 10:18 AM, Kurt Van Dijck wrote:
>> Ping
>> Marc,
>>
>> Did you look over this one.
>> I had it in a seperate thread as it covers an isolated thing.
>>
>>> Signed-off-by: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
>>> ---
>>> drivers/net/can/rx-offload.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/can/rx-offload.c b/drivers/net/can/rx-offload.c
>>> index e6a668e..a8acb2a 100644
>>> --- a/drivers/net/can/rx-offload.c
>>> +++ b/drivers/net/can/rx-offload.c
>>> @@ -238,6 +238,7 @@ unsigned int can_rx_offload_get_echo_skb(struct can_rx_offload *offload,
>>>
>>> err = can_rx_offload_queue_sorted(offload, skb, timestamp);
>>> if (err) {
>>> + kfree_skb(skb);
>> Am I right that the skb would have been lost in case the queue reached
>> it max length and you're dropping messages?
>>
>>> stats->rx_errors++;
>>> stats->tx_fifo_errors++;
>>> }
>>> --
>>> 1.8.5.rc3
>>>
> for what it is worth, I looked at it and I think is correct,
> but completely untested..
Should I add your Acked-by to the patch?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
