Re: [PATCH] can-rx-offload: free echo_skb when not queued

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ping
Marc,

Did you look over this one.
I had it in a seperate thread as it covers an isolated thing.

> Signed-off-by: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/can/rx-offload.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/can/rx-offload.c b/drivers/net/can/rx-offload.c
> index e6a668e..a8acb2a 100644
> --- a/drivers/net/can/rx-offload.c
> +++ b/drivers/net/can/rx-offload.c
> @@ -238,6 +238,7 @@ unsigned int can_rx_offload_get_echo_skb(struct can_rx_offload *offload,
>  
>  	err = can_rx_offload_queue_sorted(offload, skb, timestamp);
>  	if (err) {
> +		kfree_skb(skb);

Am I right that the skb would have been lost in case the queue reached
it max length and you're dropping messages?

>  		stats->rx_errors++;
>  		stats->tx_fifo_errors++;
>  	}
> -- 
> 1.8.5.rc3
> 



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux