Re: [PATCH v3 0/4] can: c_can/rx-offload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/8/19 10:07 AM, Kurt Van Dijck wrote:
> On di, 08 okt 2019 09:52:22 +0200, Marc Kleine-Budde wrote:
>> Date: Tue,  8 Oct 2019 09:52:22 +0200
>> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>> To: linux-can@xxxxxxxxxxxxxxx
>> Cc: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>, Joe Burmeister
>>  <joe.burmeister@xxxxxxxxxxxxx>
>> Subject: [PATCH v3 0/4] can: c_can/rx-offload
>> X-Mailer: git-send-email 2.23.0
>>
>> Hello,
>>
>> taking up Kurt's work. I've cleaned up the rx-offload and c_can patches
>> a bit. Untested as I don't have any hardware at hand.
> 
> I had created equivalent code (skb_queue in isr, skb_dequeue in napi
> handler) running on a 4.9 kernel since some days now. I didn't observe
> any problems yet.

This is based on the patches you send around. Anyways can you send me
your currently working version?

>> I just looked at the c_can and d_can datasheets. Am I right, that both
>> cores don't have a timestamp register to indicate when a CAN frame has
>> been received?
> 
> I had the same impression.
> The core clearly has not been built as a FIFO, but 'message objects'.
> Hence the magic in the isr for trying to maintain proper sequence of
> messages.

Yes. :(

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux