Re: [PATCH v2] can: c_can: c_can_poll(): only read status register after status IRQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/8/19 12:25 PM, Kurt Van Dijck wrote:
> On di, 08 okt 2019 11:57:07 +0200, Marc Kleine-Budde wrote:
>> From: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
>>
>> When the status register is read without status IRQ pending, it may get
>> into a state that it goes into busoff state without having its irq
>> activated, so the driver wil never know.
>>
>> Thanks to Wolfgang and Joe for bringing up the first idea.
>>
>> Signed-off-by: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
>> Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>
>> Cc: Joe Burmeister <joe.burmeister@xxxxxxxxxxxxx>
>> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>> ---
>> Hello,
>>
>> as mentioned in another mail, I'll take this patch for the can branch to
>> fix this problem before switching to rx-offload.
> 
> I understand. It's cleaner.

Usualy I say use top-of-tree, but having the fix backported to -stable
(with no extra effort from my side) is a good idea.

> I didn't do so as 90% of this patch will dissappear when we merge the 2
> halves together and migrate to rx-offload.

ACK. But I'd like to fix a known problem (with already a patch
available) first, before switching the driver to rx-offload.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux