Re: [PATCH v2] can: c_can: c_can_poll(): only read status register after status IRQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On di, 08 okt 2019 11:57:07 +0200, Marc Kleine-Budde wrote:
> From: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
> 
> When the status register is read without status IRQ pending, it may get
> into a state that it goes into busoff state without having its irq
> activated, so the driver wil never know.
> 
> Thanks to Wolfgang and Joe for bringing up the first idea.
> 
> Signed-off-by: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
> Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>
> Cc: Joe Burmeister <joe.burmeister@xxxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> ---
> Hello,
> 
> as mentioned in another mail, I'll take this patch for the can branch to
> fix this problem before switching to rx-offload.

I understand. It's cleaner.
I didn't do so as 90% of this patch will dissappear when we merge the 2
halves together and migrate to rx-offload.

Kurt



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux