Re: [PATCH 21/21] can: add support of SAE J1939 protocol

[Oliver Hartkopp <socketcan@xxxxxxxxxxxx>]

Hi Marc, hi Oleksij,

compiled on top of latest net-next tree:

net/can/j1939/transport.c: In function ‘j1939_tp_recv’:
net/can/j1939/transport.c:1955:19: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   skcb->addr.type = J1939_ETP;
   ~~~~~~~~~~~~~~~~^~~~~~~~~~~
net/can/j1939/transport.c:1956:2: note: here
  case J1939_TP_PGN_DAT: /* falltrough */
  ^~~~
net/can/j1939/transport.c:1961:19: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   skcb->addr.type = J1939_ETP;
   ~~~~~~~~~~~~~~~~^~~~~~~~~~~
net/can/j1939/transport.c:1962:2: note: here
  case J1939_TP_PGN_CTL: /* falltrough */
  ^~~~
net/can/j1939/transport.c: In function ‘j1939_xtp_rx_dat_one’:
net/can/j1939/transport.c:1700:6: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   if (skcb->addr.type == J1939_ETP)
      ^
net/can/j1939/transport.c:1702:2: note: here
  case J1939_TP_CMD_BAM:
  ^~~~
net/can/j1939/transport.c:1704:6: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   if (skcb->addr.type != J1939_ETP)
      ^
net/can/j1939/transport.c:1706:2: note: here
  default:
  ^~~~~~~
net/can/j1939/transport.c: In function ‘j1939_tp_cmd_recv’:
net/can/j1939/transport.c:1873:8: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   extd = J1939_ETP;
   ~~~~~^~~~~~~~~~~
net/can/j1939/transport.c:1874:2: note: here
  case J1939_TP_CMD_BAM: /* falltrough */
  ^~~~
net/can/j1939/transport.c:1894:8: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   extd = J1939_ETP;
   ~~~~~^~~~~~~~~~~
net/can/j1939/transport.c:1895:2: note: here
  case J1939_TP_CMD_CTS: /* falltrough */
  ^~~~
net/can/j1939/transport.c:1920:8: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   extd = J1939_ETP;
   ~~~~~^~~~~~~~~~~
net/can/j1939/transport.c:1921:2: note: here
  case J1939_TP_CMD_EOMA: /* falltrough */
  ^~~~

This should be fixed before upstream.

Regards,
Oliver