Hi Marc,
yes I've gone through most of it.
Some patches do not work alone out of that sequence. Does it make sense
to squash them into one?
squash patches 1-4 into one ?
5 ok
squash patches 6-7 into one ?
squash patches 8-9 into one ?
10 ok
11 ok - but my mail address is wrong :/
12 already ok
squash patches 13-15 into one ?
16-17 ok
18 Shouldn't it be CAN_REQUIRED_SIZE() ??
19-21 ok
ok -> Acked-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
I'll take a closer look into 21 - but no need to slow down the upstream
process for that.
Best,
Oliver
On 03/09/2019 11.26, Marc Kleine-Budde wrote:
On 8/28/19 11:56 AM, Oliver Hartkopp wrote:
Hi Marc,
this series only refactores & prepares the PF_CAN infrastructure to add
the J1939 support ;-)
Btw. I think I can find some time for a review on Friday.
Have you found time to look at the patches?
regards,
Marc
