Re: [PATCH] can: Add SPDX license identifiers for CAN subsystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/23/19 2:44 PM, Oliver Hartkopp wrote:
> Add missing SPDX identifiers for the CAN network layer and correct the SPDX
> license for two of its include files to make sure the BSD-3-Clause applies
> for the entire subsystem.
> 
> Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>

checkpatch complains (I'm not sure why it sees DOS line endings, though):

ERROR: DOS line endings
#96: FILE: include/linux/can/core.h:1:
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */^M$

ERROR: DOS line endings
#106: FILE: include/linux/can/skb.h:1:
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */^M$

ERROR: DOS line endings
#115: FILE: net/can/af_can.c:1:
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */^M$

WARNING: Improper SPDX comment style for 'net/can/af_can.c', please use '//' instead
#115: FILE: net/can/af_can.c:1:
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */


WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#115: FILE: net/can/af_can.c:1:
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */


ERROR: DOS line endings
#124: FILE: net/can/af_can.h:1:
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */^M$

ERROR: DOS line endings
#133: FILE: net/can/bcm.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */^M$

WARNING: Improper SPDX comment style for 'net/can/bcm.c', please use '//' instead
#133: FILE: net/can/bcm.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#133: FILE: net/can/bcm.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


WARNING: line over 80 characters
#133: FILE: net/can/bcm.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


ERROR: DOS line endings
#142: FILE: net/can/gw.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */^M$

WARNING: Improper SPDX comment style for 'net/can/gw.c', please use '//' instead
#142: FILE: net/can/gw.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#142: FILE: net/can/gw.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


WARNING: line over 80 characters
#142: FILE: net/can/gw.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


ERROR: DOS line endings
#151: FILE: net/can/proc.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */^M$

WARNING: Improper SPDX comment style for 'net/can/proc.c', please use '//' instead
#151: FILE: net/can/proc.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#151: FILE: net/can/proc.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


WARNING: line over 80 characters
#151: FILE: net/can/proc.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


ERROR: DOS line endings
#160: FILE: net/can/raw.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */^M$

WARNING: Improper SPDX comment style for 'net/can/raw.c', please use '//' instead
#160: FILE: net/can/raw.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#160: FILE: net/can/raw.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


WARNING: line over 80 characters
#160: FILE: net/can/raw.c:1:
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */


total: 8 errors, 14 warnings, 0 checks, 34 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/home/frogger/Downloads/mail/j1939/[PATCH] can: Add SPDX license identifiers for CAN subsystem.eml has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux