Re: [PATCH resend] can/ifi_canfd: Added API for IFI-CANFD functionalities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/21/19 12:55 PM, Marek Vasut wrote:
> On 7/19/19 2:52 PM, Marc Kleine-Budde wrote:
>> On 7/12/19 11:51 AM, marcel.schmidt@xxxxxxxxxxxxxxxxxxx wrote:
>>> From: Marcel Schmidt <marcel.schmidt@xxxxxxxxxxxxxxxxxxx>
>>>
>>> Updates the ifi_canfd platform driver and adds an universal
>>> interface that enables the usage of its functionalities outside of
>>> this platform driver.
>>>
>>> It was implemented with respect to role models like SJA1000 or C_Can.
>>> Therefore the driver is split into three files.
>>> ifi_canfd_platform.c contains the platform specific implementations
>>> and remains functional the same. ifi_canfd.c+h enables common IFI-CANFD
>>> functionalities usable for other drivers.
> 
> I had a quick look at the patch, but I don't quite understand what the
> goal/purpose of the patch is ?

As Marcel writes, he want to be able to use the functionalities outside
of this driver. Maybe there's another driver that makes use of this.

If there is another driver, I think it's best to include it in this
series, so that we can see if having a second driver is a good idea in
the first place.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux