Re: [PATCH v1 13/34] j1939: socket: drop sanity check for ifindex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/07/2019 19.37, Oleksij Rempel wrote:
Hi Oliver,

On Tue, Jul 09, 2019 at 07:03:12PM +0200, Oliver Hartkopp wrote:
Hi Oleksij,

the topic said what this patch does - but there's no commit message that
tells the reader why the check can be dropped.

And the removed comment in the patch leaves me even more lost ...

You right. I'll update the commit message.

Current j1939 stack implementation has one priv structure per interface.
There are no more global structures. All sockets are linked to related
priv. The can_rx call back is also configured with appropriate priv.
It means, we can't get an skb for different ifindex.

Thanks!

Feels much better now :-)

Best,
Oliver




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux