> -----Original Message-----
> From: Sean Nyekjaer <sean@xxxxxxxxxx>
> Sent: 2019年6月9日 1:42
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; mkl@xxxxxxxxxxxxxx;
> linux-can@xxxxxxxxxxxxxxx
> Cc: dl-linux-imx <linux-imx@xxxxxxx>; wg@xxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] can: flexcan: fix deadlock when using self wakeup
>
>
>
> On 17/05/2019 04.39, Joakim Zhang wrote:
> > As reproted by Sean Nyekjaer bellow:
> > When suspending, when there is still can traffic on the interfaces the
> > flexcan immediately wakes the platform again.
> > As it should :-)
> > But it throws this error msg:
> > [ 3169.378661] PM: noirq suspend of devices failed
> >
> > On the way down to suspend the interface that throws the error message
> > does call flexcan_suspend but fails to call flexcan_noirq_suspend.
> > That means the flexcan_enter_stop_mode is called, but on the way out
> > of suspend the driver only calls flexcan_resume and skips
> > flexcan_noirq_resume, thus it doesn't call flexcan_exit_stop_mode.
> > This leaves the flexcan in stop mode, and with the current driver it
> > can't recover from this even with a soft reboot, it requires a hard
> > reboot.
> >
> > Fixes: de3578c198c6 ("can: flexcan: add self wakeup support")
> >
> > This patch intends to fix the issue, and also add comment to explain
> > the wakeup flow.
> > Reported-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
>
> How is it going with the updated patch?
Hi Sean,
I still need discuss with Marc about the solution.
Joakim Zhang
> /Sean
