On Thu, Apr 25, 2019 at 02:54:16PM +0200, Kurt Van Dijck wrote: > On do, 25 apr 2019 14:31:06 +0200, Oleksij Rempel wrote: > > Hi all, > > > > please take a look at this patches. It is UAPI extension and it is good to > > know if it is sane way to track/recognize send packages. > > (1) This feedback reports success or failure for packets. > That is usefull at some point. > Is there a mechanism to track the real progress. This is something I had > in /proc somewhere, and which is usefull for larger transfers ... It can be done in the same way over error queue. The question is, what is the use case? 1. debugging? 2. provide progress bar for the GUI? 3. optimization? 4. coordination with some kind of watchdog? For example we can send notification for each transferred TP sized block of ETP transfer and make it configurable per setsocketopt. > (2) The way I see your patch, it publishes something into an error queue. > does the err queue require emptying? what happens if you don't read the err queue? Yes, the sk_error_queue require dequeuing or purging. I will need to add setsockopt to enable/disable sk_error_queue. It will be disabled by default. > > > > On 25.04.19 13:46, Oleksij Rempel wrote: > > >With this patches user space application is able to track the > > >status of (E)TP transfers. If this option is needed, application > > >should construct control message with PKTINFO->cookie set to some > > >value (for example pointer or sequence number). To get transmit status, > > >application should use recvmsg(..., MSG_ERRQUEUE). As response it will > > >get PKTINFO->cookie and error value if transfer was aborted. On success > > >error is set to zero. > > > > > >This example can be used to send data with attached control message and > > >cookie. > > > What about pktinfo interface? Are there any objections about it? -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
