[PATCH v1 02/25] j1939: socket: add fixme to j1939_sk_send_multi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
---
 net/can/j1939/socket.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/can/j1939/socket.c b/net/can/j1939/socket.c
index 5e2b5aa9ceff..2f4a29530526 100644
--- a/net/can/j1939/socket.c
+++ b/net/can/j1939/socket.c
@@ -682,6 +682,8 @@ static int j1939_sk_send_multi(struct j1939_priv *priv,  struct sock *sk,
 			 */
 			session = j1939_tp_send(priv, skb, complete_size);
 			if (IS_ERR(session))
+				/* FIXME: free skb? Who discards the skb in error case?
+				 */
 				return PTR_ERR(session);
 		} else {
 			j1939_session_skb_queue(session, skb);
-- 
2.20.1




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux