Re: [PATCH v2] can: bcm: check timer values before ktime conversion

[Oliver Hartkopp <socketcan@xxxxxxxxxxxx>]

On 22.01.19 11:26, Marc Kleine-Budde wrote:

> > +/* check limitations for timeval provided by user */
> > +static int bcm_is_invalid_tv(struct bcm_msg_head *msg_head)
>
> I've converted this into a bool function.
>
> > +{
> > +	if ((msg_head->ival1.tv_sec < 0) ||
> > +	    (msg_head->ival1.tv_sec > BCM_TIMER_SEC_MAX) ||
> > +	    (msg_head->ival1.tv_usec < 0) ||
> > +	    (msg_head->ival1.tv_usec >= USEC_PER_SEC) ||
> > +	    (msg_head->ival2.tv_sec < 0) ||
> > +	    (msg_head->ival2.tv_sec > BCM_TIMER_SEC_MAX) ||
> > +	    (msg_head->ival2.tv_usec < 0) ||
> > +	    (msg_head->ival2.tv_usec >= USEC_PER_SEC))
> > +		return 1;
>
> return true;
> > +
> > +	return 0;
>
> return false;

Thanks!

Please make sure that you do not create a pull request with this patch 
sitting in your linux-can testing tree:

https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/commit/?h=testing&id=890ea60538a41ced902981bf64b9f68739c63a29

As it is already upstream.

Best regards,
Oliver