Hi Geert,
Thank you for your feedback!
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 16 January 2019 19:06
> Subject: Re: [PATCH 08/11] clk: renesas: r8a774c0: Add missing CANFD clock
>
> Hi Fabrizio,
>
> Thanks for your patch!
>
> On Wed, Jan 16, 2019 at 7:39 PM Fabrizio Castro
> <fabrizio.castro@xxxxxxxxxxxxxx> wrote:
> > This patch adds the missing CANFD clock to the r8a774c0 specific
> > clock driver.
>
> Are you sure the CANFD clock exists on RZ/G2E?
I yet have to run tests on the board specific to CANFD, but we know for sure that's
going to appear on the RZ/G2E (if it's not in the revision of the SoC we have already).
Japan have confirmed that everything CANFD-wise should be the same as per the
corresponding Gen3 parts, and that's why are pushing this patch (and shortly
something similar for the r8a774a1) for it as it's on our critical path. Anyways, the
HW of the EK874 should support CANFD properly, therefore I am going to try and
run some tests (as soon as I sort out the cables), so that we clear any doubts.
Would you rather we held back all of the CAN related changes for now?
>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>
>
> > --- a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> > +++ b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
>
> > --- a/include/dt-bindings/clock/r8a774c0-cpg-mssr.h
> > +++ b/include/dt-bindings/clock/r8a774c0-cpg-mssr.h
> > @@ -48,13 +48,14 @@
> > #define R8A774C0_CLK_ZA2 37
> > #define R8A774C0_CLK_ZA8 38
> > #define R8A774C0_CLK_Z2D 39
> > -#define R8A774C0_CLK_MSO 40
> > -#define R8A774C0_CLK_R 41
> > -#define R8A774C0_CLK_OSC 42
> > -#define R8A774C0_CLK_LV0 43
> > -#define R8A774C0_CLK_LV1 44
> > -#define R8A774C0_CLK_CSI0 45
> > -#define R8A774C0_CLK_CP 46
> > -#define R8A774C0_CLK_CPEX 47
> > +#define R8A774C0_CLK_CANFD 40
> > +#define R8A774C0_CLK_MSO 41
> > +#define R8A774C0_CLK_R 42
> > +#define R8A774C0_CLK_OSC 43
> > +#define R8A774C0_CLK_LV0 44
> > +#define R8A774C0_CLK_LV1 45
> > +#define R8A774C0_CLK_CSI0 46
> > +#define R8A774C0_CLK_CP 47
> > +#define R8A774C0_CLK_CPEX 48
>
> This file is part of the DT ABI, hence list of definitions is append-only.
Will fix this with a v2
Thanks,
Fab
>
> Please add R8A774C0_CLK_CANFD at the end, i.e.
>
> #define R8A774C0_CLK_CANFD 48
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
