On Thu, Jan 03, 2019 at 10:03:47PM +0100, Oliver Hartkopp wrote: > 1. I'm still using the test "if (cf->can_dlc > 8)" with a proper comment as > CAN_MAX_DLC and CAN_MAX_DLEN are not defined in Linux stable 3.2 - so that > we can apply the patch to all versions of gw.c I may be biased as substantial part of my work consists of trying to understand unfamiliar code written by other people but I believe readability of the code is more important than avoiding a bit of work with backport to older stable branches. Michal Kubecek