Hi Oliver > -----Original Message----- > From: Oliver Hartkopp [mailto:socketcan@xxxxxxxxxxxx] > Sent: Friday, August 3, 2018 12:15 AM > To: Pankaj Bansal <pankaj.bansal@xxxxxxx>; linux-can@xxxxxxxxxxxxxxx; > mkl@xxxxxxxxxxxxxx > Subject: Re: [PATCH v1] net: can: flexcan: can FD Format (FDF) changes > > Hi Pankaj, > > On 08/02/2018 10:14 AM, Pankaj Bansal wrote: > > Signed-off-by: Pankaj Bansal <pankaj.bansal@xxxxxxx> > > > +static const struct flexcan_devtype_data fsl_lx2160a_r1_devtype_data > = { > > + .quirks = FLEXCAN_QUIRK_DISABLE_RXFG | > FLEXCAN_QUIRK_ENABLE_EACEN_RRS | > > + FLEXCAN_QUIRK_DISABLE_MECR | > FLEXCAN_QUIRK_BROKEN_PERR_STATE | > > + FLEXCAN_QUIRK_USE_OFF_TIMESTAMP | > FLEXCAN_QUIRK_USE_FD, }; > > + > > static const struct can_bittiming_const flexcan_bittiming_const = { > > .name = DRV_NAME, > > .tseg1_min = 4, > > @@ -321,6 +359,30 @@ static const struct can_bittiming_const > flexcan_bittiming_const = { > > .brp_inc = 1, > > }; > > > > +static const struct can_bittiming_const > extended_flexcan_bittiming_const = { > > + .name = "Extended flexcan", > > + .tseg1_min = 2, > > (..) > > > +static const struct can_bittiming_const flexcan_data_bittiming_const = { > > + .name = "CAN FD flexcan", > > + .tseg1_min = 2, > > > I remember at least some comments regarding the .name tag from Marc > (which should be set to DRV_NAME). Can you send an update incorporating > Marcs comments too? Actually Marc asked me to put "DRV_NAME" in .name field of bit timings. But I thought that this .name field is there to distinguish between different bit timings or for providing some details about them. That is why I have put information relevant to the bit timings in .name field. If this field is just to get the name of module to which the bit timings belong, then I will put "DRV_NAME" in it. > > Tnx, > Oliver ��.n��������+%������w��{.n�����{����* jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
