Re: [PATCH v1] net: can: flexcan: can FD Format (FDF) changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pankaj,

On 08/02/2018 10:14 AM, Pankaj Bansal wrote:
Signed-off-by: Pankaj Bansal <pankaj.bansal@xxxxxxx>

+static const struct flexcan_devtype_data fsl_lx2160a_r1_devtype_data = {
+	.quirks = FLEXCAN_QUIRK_DISABLE_RXFG | FLEXCAN_QUIRK_ENABLE_EACEN_RRS |
+		FLEXCAN_QUIRK_DISABLE_MECR | FLEXCAN_QUIRK_BROKEN_PERR_STATE |
+		FLEXCAN_QUIRK_USE_OFF_TIMESTAMP | FLEXCAN_QUIRK_USE_FD,
+};
+
  static const struct can_bittiming_const flexcan_bittiming_const = {
  	.name = DRV_NAME,
  	.tseg1_min = 4,
@@ -321,6 +359,30 @@ static const struct can_bittiming_const flexcan_bittiming_const = {
  	.brp_inc = 1,
  };
+static const struct can_bittiming_const extended_flexcan_bittiming_const = {
+	.name = "Extended flexcan",
+	.tseg1_min = 2,

(..)

+static const struct can_bittiming_const flexcan_data_bittiming_const = {
+	.name = "CAN FD flexcan",
+	.tseg1_min = 2,


I remember at least some comments regarding the .name tag from Marc (which should be set to DRV_NAME). Can you send an update incorporating Marcs comments too?

Tnx,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux