Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote: > + This permits on-demand read mode of cachefiles. In this mode, when > + cache miss, the cachefiles backend instead of netfs, is responsible > + for fetching data, e.g. through user daemon. That third line should probably begin with a tab as the other two line do. > +static inline void cachefiles_flush_reqs(struct cachefiles_cache *cache) If it's in a .c file, there's no need to mark it "inline". The compiler will inline it anyway if it decides it should. > +#ifdef CONFIG_CACHEFILES_ONDEMAND > + cachefiles_flush_reqs(cache); > + xa_destroy(&cache->reqs); > +#endif If cachefiles_flush_reqs() is only used in this one place, the xa_destroy() should possibly be moved into it. David -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs
